> On April 1, 2020, 9:02 a.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 1379 (patched) > > <https://reviews.apache.org/r/72290/diff/1/?file=2216627#file2216627line1410> > > > > Will this issue unnecessary queries for read only queries? For Oracle > > this could increase exexution time > > > > Also why not use executeQueryiesInBatch for this?
As discussed, in the current state, these delete queries are executed every time during commitTxn (not during abortTxn). Regarding reusing executeQueryiesInBatch, that's a good point, will do. - Marton ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72290/#review220167 ----------------------------------------------------------- On April 1, 2020, 6:53 a.m., Marton Bod wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72290/ > ----------------------------------------------------------- > > (Updated April 1, 2020, 6:53 a.m.) > > > Review request for hive, Denys Kuzmenko and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-23067: Use batch DB calls in TxnHandler for commitTxn and abortTxns > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 74ef88545e > > > Diff: https://reviews.apache.org/r/72290/diff/1/ > > > Testing > ------- > > Green build: https://builds.apache.org/job/PreCommit-HIVE-Build/21347/ > > > Thanks, > > Marton Bod > >
