-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72336/
-----------------------------------------------------------
Review request for hive and Peter Vary.
Bugs: HIVE-23114
https://issues.apache.org/jira/browse/HIVE-23114
Repository: hive-git
Description
-------
The idea behind the patch is the following:
When doing a multi-statement insert overwrite with dynamic partitioning, the
partition information will be written to the manifest file. With this
information, each FileSinkOperator can clean-up only the partition directories
written by the same FileSinkOperator and do not clean-up the partition
directories written by the other FileSinkOperators.
If a statement from the insert overwrite query, doesn't produce any data, a
manifest file will still be written, otherwise the missing manifest file would
result a clean-up on table level which could delete the data written by the
other FileSinkOperators.
Diffs
-----
itests/src/test/resources/testconfiguration.properties e99ce7babb
ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractFileMergeOperator.java
d68d8f9409
ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 04166a23ee
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java e25dc54e7d
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 17e6cdf162
ql/src/test/queries/clientpositive/acid_direct_insert_insert_overwrite.q
PRE-CREATION
ql/src/test/queries/clientpositive/acid_multiinsert_dyn_part.q PRE-CREATION
ql/src/test/results/clientpositive/acid_direct_insert_insert_overwrite.q.out
PRE-CREATION
ql/src/test/results/clientpositive/acid_multiinsert_dyn_part.q.out
PRE-CREATION
ql/src/test/results/clientpositive/llap/acid_direct_insert_insert_overwrite.q.out
PRE-CREATION
ql/src/test/results/clientpositive/llap/acid_multiinsert_dyn_part.q.out
PRE-CREATION
Diff: https://reviews.apache.org/r/72336/diff/1/
Testing
-------
Added specific q tests for different insert overwrite scenarios.
Thanks,
Marta Kuczora
