----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72359/#review220308 -----------------------------------------------------------
Thanks for the patch Marton! Some questions, ideas. Thanks, Peter standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 1248 (original), 1228 (patched) <https://reviews.apache.org/r/72359/#comment308641> Is this 'rs' not reused later? Maybe use a local scoped rs here? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Lines 1325 (patched) <https://reviews.apache.org/r/72359/#comment308643> Not really important since this is a private method, but why not return boolean instead? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Lines 1351 (patched) <https://reviews.apache.org/r/72359/#comment308644> Maybe log the query in debug level? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Lines 1375 (patched) <https://reviews.apache.org/r/72359/#comment308642> Might worth to initialize with a size - Peter Vary On ápr. 14, 2020, 8:57 de, Marton Bod wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72359/ > ----------------------------------------------------------- > > (Updated ápr. 14, 2020, 8:57 de) > > > Review request for hive, Denys Kuzmenko and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-23104: Minimize critical paths of TxnHandler::commitTxn and abortTxn > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 7d0db0c3a0 > > > Diff: https://reviews.apache.org/r/72359/diff/1/ > > > Testing > ------- > > Green build: > https://builds.apache.org/job/PreCommit-HIVE-Build/21539/testReport > Benchmark results attached to ticket: > https://issues.apache.org/jira/browse/HIVE-23104 > > > Thanks, > > Marton Bod > >
