> On April 16, 2020, 9:24 a.m., Peter Vary wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > Lines 650-651 (patched) > > <https://reviews.apache.org/r/72360/diff/1/?file=2217548#file2217548line650> > > > > The text describing the config value is for administrators and not for > > developers. So this part should be a java comment instead of being part of > > the description
moved into a comment > On April 16, 2020, 9:24 a.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 2520-2525 (patched) > > <https://reviews.apache.org/r/72360/diff/1/?file=2217550#file2217550line2520> > > > > I would do it in setConf, like we did with the numOpenTxns and friends makes perfect sense, updated the diff - Marton ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72360/#review220331 ----------------------------------------------------------- On April 14, 2020, 2:25 p.m., Marton Bod wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72360/ > ----------------------------------------------------------- > > (Updated April 14, 2020, 2:25 p.m.) > > > Review request for hive, Denys Kuzmenko and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-23093: Create new metastore config value for jdbc max batch size > > > Diffs > ----- > > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > 3bfb0e69cb > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java > a66e16973f > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 331fd4cc8d > > > Diff: https://reviews.apache.org/r/72360/diff/2/ > > > Testing > ------- > > > Thanks, > > Marton Bod > >
