----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72423/ -----------------------------------------------------------
(Updated April 27, 2020, 5:29 p.m.) Review request for hive, Jesús Camacho Rodríguez and Vineet Garg. Bugs: HIVE-23089 https://issues.apache.org/jira/browse/HIVE-23089 Repository: hive-git Description ------- Add constraint checks to CBO plan Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java f94a9f9d70 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 0de3730351 ql/src/java/org/apache/hadoop/hive/ql/parse/type/ConstraintExprGenerator.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/parse/type/ExprNodeTypeCheck.java 3e3d331412 ql/src/java/org/apache/hadoop/hive/ql/parse/type/RexNodeTypeCheck.java c9131ec018 ql/src/test/results/clientnegative/update_notnull_constraint.q.out 32905378e7 ql/src/test/results/clientpositive/llap/check_constraint.q.out bc5d361859 ql/src/test/results/clientpositive/llap/default_constraint.q.out a04da4e2b4 ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out e96363fe29 Diff: https://reviews.apache.org/r/72423/diff/4/ Changes: https://reviews.apache.org/r/72423/diff/3-4/ Testing ------- mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=check_constraint.q,sort_acid.q -pl itests/qtest -Pitests mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestNegativeCliDriver -Dqfile=update_notnull_constraint.q -pl itests/qtest -Pitests Thanks, Krisztian Kasa