----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72472/#review220652 -----------------------------------------------------------
LGTM, minor comments ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java Line 3158 (original) <https://reviews.apache.org/r/72472/#comment309220> nit: new line ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseUtils.java Line 104 (original), 108 (patched) <https://reviews.apache.org/r/72472/#comment309221> nit: I would just use ternary operator in-place, it's easier to understand why the fallback - Denys Kuzmenko On May 5, 2020, 8:58 a.m., Marton Bod wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72472/ > ----------------------------------------------------------- > > (Updated May 5, 2020, 8:58 a.m.) > > > Review request for hive, Denys Kuzmenko, Jesús Camacho Rodríguez, and Peter > Vary. > > > Repository: hive-git > > > Description > ------- > > Introduces a new TxnType for materialization view rebuilds, and only issues > rebuild lock delete calls during commit for that specific type > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 998c05e37d > ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseUtils.java e91a7ed760 > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TxnType.java > 349f37f914 > > standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php > e4b0bc726c > > standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py > 1a0fee319b > > standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb > e6224ec16f > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift > 8462b3d7a3 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 8fded608d0 > > > Diff: https://reviews.apache.org/r/72472/diff/2/ > > > Testing > ------- > > > Thanks, > > Marton Bod > >
