----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72112/ -----------------------------------------------------------
(Updated May 12, 2020, 11:38 a.m.) Review request for hive, Denys Kuzmenko, Aron Hamvas, Marton Bod, and Peter Vary. Repository: hive-git Description ------- Add the possibility to run benchmarks on opening lock in the HMS. Currently this change only introduces single-threaded/single client testing. I'm planning to add multi-client support in a separate change. Example parametrisation is as follows: hbench -M "lock" -N 10 -d hive_test -W 0 -L 100 hbench -M ".*Lock.*" -N 10 -d hive_test -W 0 -L 100 -T 8 --params 100 This will create N number (10) of tables to lock and it'll execute the lock() for L number (100) of times on T (8) threads where each thread will strart an HMS client Diffs (updated) ----- standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/BenchmarkTool.java 2ab9388301 standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSBenchmarks.java d80c290b60 standalone-metastore/metastore-tools/tools-common/src/main/java/org/apache/hadoop/hive/metastore/tools/BenchmarkSuite.java 5211082a7d standalone-metastore/metastore-tools/tools-common/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSClient.java 4e75edeae6 standalone-metastore/metastore-tools/tools-common/src/main/java/org/apache/hadoop/hive/metastore/tools/Util.java 101d6759c5 Diff: https://reviews.apache.org/r/72112/diff/2/ Changes: https://reviews.apache.org/r/72112/diff/1-2/ Testing ------- File Attachments (updated) ---------------- HIVE-22869.2.patch https://reviews.apache.org/media/uploaded/files/2020/04/02/5e35e835-f383-495f-9964-e66773fd6a90__HIVE-22869.2.patch HIVE-22869.3.patch https://reviews.apache.org/media/uploaded/files/2020/04/09/458beaa7-4743-40fb-a213-1ae4527be823__HIVE-22869.3.patch HIVE-22869.4.patch https://reviews.apache.org/media/uploaded/files/2020/04/23/423c45d7-911e-4dd2-80b8-c6d3ad90633c__HIVE-22869.4.patch HIVE-22869.5.patch https://reviews.apache.org/media/uploaded/files/2020/05/12/a06f3b8c-f4ca-4067-a079-e0b6185266d4__HIVE-22869.5.patch Thanks, Zoltan Chovan