----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72462/#review220823 -----------------------------------------------------------
ql/src/test/results/clientnegative/msck_repair_6.q.out Lines 30 (patched) <https://reviews.apache.org/r/72462/#comment309534> Can we return more specific error code instead of 1? ql/src/test/results/clientpositive/msck_repair_4.q.out Lines 34 (patched) <https://reviews.apache.org/r/72462/#comment309533> Why the show partitions output is listed in the output file? We need to have it to validate this scenario. standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/CheckResult.java Lines 184 (patched) <https://reviews.apache.org/r/72462/#comment309584> Do we need this override as it just calls super method? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreChecker.java Lines 415 (patched) <https://reviews.apache.org/r/72462/#comment309585> Shall log the table name as well. standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreChecker.java Line 405 (original), 419 (patched) <https://reviews.apache.org/r/72462/#comment309586> Should we also validate the case where old path(lower case) of partition is removed but added same path with different case? In this case, partition exist in both partitionsNotOnFs and partitionsNotInMs lists. Not sure, if it can cause any failures. - Sankar Hariappan On May 18, 2020, 10:43 a.m., Adesh Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72462/ > ----------------------------------------------------------- > > (Updated May 18, 2020, 10:43 a.m.) > > > Review request for hive and Sankar Hariappan. > > > Repository: hive-git > > > Description > ------- > > The fix converts partition keys to lowercase present in hdfs directory, but > store the hdfs directory as is for partition path. > > > Diffs > ----- > > > ql/src/test/org/apache/hadoop/hive/ql/exec/TestMsckCreatePartitionsInBatches.java > 7821f40a82 > ql/src/test/queries/clientnegative/msck_repair_5.q PRE-CREATION > ql/src/test/queries/clientnegative/msck_repair_6.q PRE-CREATION > ql/src/test/queries/clientpositive/msck_repair_4.q PRE-CREATION > ql/src/test/queries/clientpositive/msck_repair_5.q PRE-CREATION > ql/src/test/queries/clientpositive/msck_repair_6.q PRE-CREATION > ql/src/test/results/clientnegative/msck_repair_5.q.out PRE-CREATION > ql/src/test/results/clientnegative/msck_repair_6.q.out PRE-CREATION > ql/src/test/results/clientpositive/msck_repair_4.q.out PRE-CREATION > ql/src/test/results/clientpositive/msck_repair_5.q.out PRE-CREATION > ql/src/test/results/clientpositive/msck_repair_6.q.out PRE-CREATION > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/CheckResult.java > 5287f47e21 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreChecker.java > 6f4400a8ef > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java > f4e109d1b0 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java > 92d10cd0e1 > > > Diff: https://reviews.apache.org/r/72462/diff/5/ > > > Testing > ------- > > > Thanks, > > Adesh Rao > >
