[
https://issues.apache.org/jira/browse/HIVE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186862#comment-13186862
]
Phabricator commented on HIVE-2691:
-----------------------------------
cwsteinbach has requested changes to the revision "HIVE-2691 [jira] Specify
location of log4j configuration files via configuration properties".
INLINE COMMENTS
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:566 Shouldn't
CliSessionState be initialized after logging is initialized?
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:565 Better to just
call this "conf" instead of "log4jconf"
common/src/java/org/apache/hadoop/hive/common/LogUtils.java:105 Please move
this piece of code back to ExecDriver. It's out of place here.
common/src/java/org/apache/hadoop/hive/common/LogUtils.java:87 This code does
not belong here.
common/src/java/org/apache/hadoop/hive/common/LogUtils.java:102 What about
HIVE_EXEC_L4J?
common/src/java/org/apache/hadoop/hive/common/LogUtils.java:119 Please change
this method to return void and instead write to the log directly from this
method.
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:902 Remove this
method. Folks can call getPath() on their own.
common/src/java/org/apache/hadoop/hive/common/LogUtils.java:55 initHiveLog4j
can create its own HiveConf object, in which case you don't need to check to
see if the input arg is null. I think this approach is preferable.
REVISION DETAIL
https://reviews.facebook.net/D1203
> Specify location of log4j configuration files via configuration properties
> --------------------------------------------------------------------------
>
> Key: HIVE-2691
> URL: https://issues.apache.org/jira/browse/HIVE-2691
> Project: Hive
> Issue Type: New Feature
> Components: Configuration, Logging
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2691.D1131.1.patch, HIVE-2691.D1203.1.patch,
> HIVE-2691.D1203.2.patch, HIVE-2691.D1203.3.patch, HIVE-2691.D1203.4.patch,
> HIVE-2691.D1203.5.patch
>
>
> Oozie needs to be able to override the default location of the log4j
> configuration
> files from the Hive command line, e.g:
> {noformat}
> hive -hiveconf hive.log4j.file=/home/carl/hive-log4j.properties -hiveconf
> hive.log4j.exec.file=/home/carl/hive-exec-log4j.properties
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
