Stamatis Zampetakis created HIVE-24018:

             Summary: Review necessity of 
AggregationDesc#setGenericUDAFWritableEvaluator for bloom filter aggregations
                 Key: HIVE-24018
             Project: Hive
          Issue Type: Improvement
            Reporter: Stamatis Zampetakis
            Assignee: Stamatis Zampetakis

Few places in the code have following pattern 
GenericUDAFBloomFilterEvaluator bloomFilterEval = new 
AggregationDesc bloom = new AggregationDesc("bloom_filter", bloomFilterEval, p, 
false, mode);
where the bloom filter evaluator is passed in the constructor of the 
aggregation and  directly after using a setter. The use of the setter is 
necessary otherwise there are runtime failures of the query however the pattern 
is a bit confusing. 

Investigate if there is a way to avoid the double passing of the evaluator. 

To reproduce the failure remove the setter and run the following test.
mvn test -Dtest=TestMiniLlapLocalCliDriver 
-Dqfile=vectorized_dynamic_semijoin_reduction.q -Dtest.output.overwrite 

This message was sent by Atlassian Jira

Reply via email to