Rajesh Balamohan created HIVE-24289: ---------------------------------------
Summary: RetryingMetaStoreClient should not retry connecting to HMS on genuine errors Key: HIVE-24289 URL: https://issues.apache.org/jira/browse/HIVE-24289 Project: Hive Issue Type: Improvement Reporter: Rajesh Balamohan When there is genuine error from HMS, it should not be retried in RetryingMetaStoreClient. For e.g, following query would be retried multiple times (~20+ times) in HMS causing huge delay in processing, even though this constraint is available in HMS. It should just throw exception to client and stop retrying in such cases. {noformat} alter table web_sales add constraint tpcds_bin_partitioned_orc_10000_ws_s_hd foreign key (ws_ship_hdemo_sk) references household_demographics (hd_demo_sk) disable novalidate rely; org.apache.hadoop.hive.ql.metadata.HiveException: org.apache.thrift.TApplicationException: Internal error processing add_foreign_key at org.apache.hadoop.hive.ql.metadata.Hive.addForeignKey(Hive.java:5914) .. ... Caused by: org.apache.thrift.TApplicationException: Internal error processing add_foreign_key at org.apache.thrift.TApplicationException.read(TApplicationException.java:111) at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:79) at org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.recv_add_foreign_key(ThriftHiveMetastore.java:1872) {noformat} https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java#L256 For e.g, if exception contains "Internal error processing ", it could stop retrying all over again. -- This message was sent by Atlassian Jira (v8.3.4#803005)