David Mollitor created HIVE-24772:
-------------------------------------
Summary: Revamp Server Error Logging
Key: HIVE-24772
URL: https://issues.apache.org/jira/browse/HIVE-24772
Project: Hive
Issue Type: Improvement
Reporter: David Mollitor
Assignee: David Mollitor
Most of the action takes place in {{ThriftCLIService}} where errors are logged
in response to client requests (though I know in many instances things are
logged multiple times).
I propose to improve this on multiple fronts:
# Many log messages have the word "Error" in it, but log at the WARN level. I
have changed all relevant logging to be at ERROR level and removed the word
"Error" from the message
# Some of the error message in the logging code had copy & paste errors where
they printed the wrong request name
# Print the actual request object in the error message
# Big one for me: Do not pass a stack trace to the client. This is bad
practice from a security perspective,... clients should not know that level of
detail of the server, and also it's very confusing for the client perspective
to understand that the stack trace is actually from the remote server, not the
local client, and finally, it's too messy for a typical user to deal with
anyway. Stack trace should be presented in the HS2 logs only.
# Various clean up
# Log an IP address for the client as part of standard operating procedure
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
