CoolGuy created HIVE-25447:
------------------------------
Summary: Proposal for commented code
Key: HIVE-25447
URL: https://issues.apache.org/jira/browse/HIVE-25447
Project: Hive
Issue Type: Wish
Reporter: CoolGuy
Hello! I saw in your [contributing
guidelines|https://cwiki.apache.org/confluence/display/Hive/HowToContribute]
that ?? Please do not comment out code that is now obsolete: just remove it;
??
However, I still witness commented code in some files like:
storage-api/src/java/org/apache/hadoop/hive/ql/util/JavaDataModel.java
storage-api/src/java/org/apache/hadoop/hive/common/type/FastHiveDecimalImpl.java
ql/src/java/org/apache/hadoop/hive/ql/exec/DataSketchesFunctions.java
and so on.
I identified at least 800 commented code lines with a simple script.
Would you like to remove these commented codes?
If so, I may help and open a pull request.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
