Thanks Peter for taking care of this, I can confirm that "master" is good now!
On Wed, 16 Mar 2022 at 12:30, Peter Vary <pv...@cloudera.com.invalid> wrote: > The tests should be green now... > > > On 2022. Mar 15., at 14:45, Stamatis Zampetakis <zabe...@gmail.com> > wrote: > > > > Hello, > > > > +1 to everything Peter said. > > > > Moreover a few other things/reminders which could make our life easier. > > > > No commits/merges over broken master. > > > > If there is a non-flaky failure in master then whoever notices it first, > > please create a JIRA and add any relevant info. This will notify everyone > > that there is a problem and it will also avoid having multiple people > > looking at it. > > > > If there is failure in master or during precommit tests that seems to be > > intermittent please run the flaky checker job [1]. If the result shows > it's > > flaky, log a JIRA and raise a PR disabling the test if there is no quick > > fix available. > > > > Rerun precommit tests before merging a pull request if the latest > precommit > > run is old (e.g., greater than 72h). > > > > Best, > > Stamatis > > > > [1] http://ci.hive.apache.org/job/hive-flaky-check/ > > > > > > On Mon, Mar 14, 2022 at 9:31 PM Peter Vary <pv...@cloudera.com.invalid> > > wrote: > > > >> If I remember correctly the decision was to not to merge changes with > >> failing PreCommit tests. > >> > >> Lately, because of a mistake where the change was only partially merged, > >> we had a failing test. > >> I have tried to fix this issue and confirm it by rerunning the tests, > but > >> the check failed again. Now it failed with some different tests, > because in > >> the meantime there were some more failing tests were committed to > master in > >> the meantime. > >> > >> I think it would be good to stick to the previous decision and we should > >> only commit changes if all of the tests are green. Also if there are > some > >> issues then it would be good to take the time to fix the failures or > revert > >> the changes causing the issues. > >> > >> Thanks, > >> Peter > >> > >> > >> > >
