Hi Team, I have seen that the CI test are continuously failing with the following errors:
Check warning on line 18 in serde/src/java/org/apache/hadoop/hive/serde2/esriJson/deserializer/SpatialReferenceJsonDeserializer.java GitHub Actions / Spell checking serde/src/java/org/apache/hadoop/hive/serde2/esriJson/deserializer/SpatialReferenceJsonDeserializer.java#L18 `esri` is not a recognized word. Sourabh Badhya kindly helped me identifying the commit which caused this issue: https://github.com/apache/hive/commit/0099b14aa6a50d4470b057e93a95a7391b74add7 <https://github.com/apache/hive/commit/0099b14aa6a50d4470b057e93a95a7391b74add7> The jira for the change is: https://issues.apache.org/jira/browse/HIVE-25733 <https://issues.apache.org/jira/browse/HIVE-25733> To fix the issues I pushed an addendum: https://github.com/apache/hive/commit/0b4e466866fe07a160b0e4b0c27d2b3fb7613c45 <https://github.com/apache/hive/commit/0b4e466866fe07a160b0e4b0c27d2b3fb7613c45> Hopefully after a rebase all of the tests should be green now (the first tests are running now). The new tests add a spellcheck for the CI. Currently it runs only for the `serde` package. The check parses the code files, and if it founds some unrecognisable / non-dictionary words, then it throws an error. This could be useful for catching spelling errors not recognised by the reviewers, but keeping the exception list (in .github/actions/spelling/expect.txt) might become cumbersome. Currently we have 452 entries in the file for the `serde` package alone. I would like to hear the community’s opinion whether we would like to keep it and use it for other modules as well. Thanks, Peter