[
https://issues.apache.org/jira/browse/HIVE-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192777#comment-13192777
]
Phabricator commented on HIVE-2746:
-----------------------------------
cwsteinbach has commented on the revision "HIVE-2746 [jira] Metastore client
doesn't log properly in case of connection failure to server".
INLINE COMMENTS
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:292
Ok, I think I'm getting confused by the inconsistent indentation in this
method (can you fix that?). It looks to me like the block of code that attempts
to set the ugi should be taken out of the for-loop and moved below the
!isConnected check. Does that make sense? Otherwise we're just polluting the
log with noise every time a connection attempt fails.
REVISION DETAIL
https://reviews.facebook.net/D1395
> Metastore client doesn't log properly in case of connection failure to server
> -----------------------------------------------------------------------------
>
> Key: HIVE-2746
> URL: https://issues.apache.org/jira/browse/HIVE-2746
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.8.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: HIVE-2746.D1395.1.patch
>
>
> LOG.error(e.getStackTrace()) in current code prints memory location of
> StackTraceElement[] instead of message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
