Hi all, I'm in the process of trying to allow CBO to work for lateral views.
Personally, I find myself allergic to 5000+ line java files (heh, turning a blind eye to SemanticAnalyzer for now), If I add code to genLateralViewPlans(), I'm gonna be making it even worse. I kinda feel like I should extract the 150 line method genLateralViewPlans and put it in its own class. But by doing that, there are 2 calls to methods within SemanticAnalyzer and BaseSemanticAnalzyer that I would also want to move into a more generic place. It wouldn't be too much to get this to work (the 2 methods are small utility methods) but it does give me pause to start moving things around that people are used to. How do we feel about a general refactor of CalcitePlanner (and potentially BaseSemanticAnalyzer and SemanticAnalyzer at some point)? Do people in the community feel like it would be too disruptive? Would it just make things harder to trace history via git blame that it's more trouble than it's worth at this point? I'm not sure how I feel about that point. Just wanted to get some opinions before I do anything. Thanks!
