Hi, everyone. I have not tested the master branch with Java 11/17 yet, but I would like to share my experience with testing a fork of branch-3.1 with Java 11/17 (as part of developing Hive-MR3), in case that it can be useful for the discussion. I merged the patches listed in [1] HIVE-22415 and updated the Maven configuration for Java 11.
1. Building Hive was fine and I was able to run it with Java 11 as well as Java 17. So, it seems that the work reported in [1] is indeed complete for upgrading to Java 11 (and Java 17) and getting Hive to work. 2. However, there was a problem with running tests, so this can be additional work for upgrading to Java 11. 3. For performance, Java 17 gives about 8 percent of (free) performance improvement. When tested with 10TB TPC-DS, Java 8 takes 8074 seconds, whereas Java 17 takes 7415 seconds. Considering the maturity of Hive, I think this is not a small improvement because almost every query gets some speedup. Thanks, --- Sungwoo [1] https://issues.apache.org/jira/browse/HIVE-22415 On Thu, Jun 1, 2023 at 3:53 AM Sai Hemanth Gantasala <saihema...@cloudera.com.invalid> wrote: > Hi All, > > I would strongly advocate keeping support for JDK8. > Between JDK11 and JDK17, Depending on the amount of effort on the upgrade > I'm inclined towards JDK17 (JDK21 LTS will be released in Sep 2023). > > Thanks, > Sai. > > On Wed, May 31, 2023 at 5:39 AM László Bodor <bodorlaszlo0...@gmail.com> > wrote: > > > *Hi!* > > > > > > *Should we support both JDK-11 & JDK-8?* > > IMO absolutely yes, let's not break up with JDK-8: according to its > > lifecycle, it's going to stay with us for a long time. > > > > I believe > > a) we should be able to compile on JDK8, JDK11, and JDK17 (github actions > > can cover this conveniently in precommit time, like tez > > <https://github.com/apache/tez/blob/master/.github/workflows/build.yml>) > > b) the release artifacts should be compatible with JDK8 as long as it is > > with us. > > > > Regards, > > Laszlo Bodor > > > > > > Butao Zhang <butaozha...@163.com> ezt írta (időpont: 2023. máj. 31., > Sze, > > 14:33): > > > > > Thanks Ayush for driving this! Good to know that Hive is getting ready > > for > > > newer JDK. > > > From my opinon, if we have more community energy to put into it, we can > > > support both JDK-11 and JDK-17 like Spark[1]. If we have to make a > > choice > > > between a JDK-11 and JDK-17, i would like to choose the relatively new > > > version JDK-17, meanwhile, we should maintain compatibility with jdk8, > as > > > JDK-8 is still widely used in most big data platforms. > > > > > > > > > Thanks, > > > Butao Zhang > > > > > > > > > [1]https://issues.apache.org/jira/browse/SPARK-33772 > > > ---- Replied Message ---- > > > | From | Ayush Saxena<ayush...@gmail.com> | > > > | Date | 5/31/2023 18:39 | > > > | To | dev<dev@hive.apache.org> | > > > | Subject | Move to JDK-11 | > > > Hi Everyone, > > > Want to pull in the attention of folks towards moving to JDK-11 compile > > > time support in Hive. There was a ticket in the past [1] which talks > > about > > > it and If I could decode it right, it was blocked because the Hadoop > > > version used by Hive didn't had JDK-11 runtime support, But with [2] in > > we > > > have upgraded the Hadoop version, so that problem is sorted out. I > > couldn't > > > even see any unresolved tickets in the blocked state either. > > > > > > I quickly tried* a mvn clean install -DskipTests -Piceberg -Pitests > > > -Dmaven.javadoc.skip=true > > > > > > And no surprises it failed with some weird exceptions towards the end. > > But > > > I think that should be solvable. > > > > > > So, Questions? > > > > > > - What do folks think about this? Should we put in some effort towards > > > JDK-11 > > > - Should we support both JDK-11 & JDK-8? > > > - Ditch JDK-11 and directly shoot for JDK-17? > > > > > > Let me know your thoughts, In case anyone has some experience in this > > area > > > and have tried something in the context, feel free to share or may be > if > > > someone has any potential action plan or so > > > > > > -Ayush > > > > > > [1] https://issues.apache.org/jira/browse/HIVE-22415 > > > [2] https://issues.apache.org/jira/browse/HIVE-24484 > > > > > > * changed the maven.compiler.source & maven.compiler.target to 11 > > > > > >
