Hi Zhihua,
Thanks for preparing the release! +1(non-binding) * Downloaded the source tarball, signature (.asc), and checksum: ✓ OK * Imported GPG keys and verified the signature: ✓ OK (Observed that the signature is good, from Zhihua Deng, with a warning that the sign key is not certified with a trusted signature) * Validated checksum and signature for the artifacts: ✓ OK * Successfully built from sources: ✓ OK * Initialized HMS schema using meta init scripts against PostgresSQL: ✓ OK * Confirmed successful standalone metastore setup with PostgresSQL: ✓ OK * Deployed and started HiveServer2 and Metastore with Hadoop 3.3.1 and Tez 0.10.3-SNAPSHOT: ✓ OK * Connected via Beeline, created a Hive-ACID ORC table and run a few insert/select/update/delete queries ✓ OK * Connected via Beeline, created an Iceberg ORC table and run a few insert/select/update/delete queries ✓ OK Thanks, Dmitriy Fingerman (difin) On Fri, Sep 27, 2024 at 9:47 AM Okumin <m...@okumin.com> wrote: > Hi Zhihua, > > Thanks for preparing the release. > > +1(non-binding) > > - Checksum: OK > - GPG verify: OK > - All changes labeled with "hive-4.0.1-must" are included in > 3af4517eb8cfd9407ad34ed78a0b48b57dfaa264: OK > - Build and basic queries with Tez 0.10.4 and Hive 4.0.1: OK > > I compared the git history with Jira tickets. > - Git: git log > rel/release-4.0.0...3af4517eb8cfd9407ad34ed78a0b48b57dfaa264 > --pretty=format:"%s" | sort > - Jira: fix version=4.0.1 > > I found some differences. We may have some additional JIRA work. > - HIVE-19741 is included only in JIRA. This is OK since this ticket > changes only the document on Confluence > - HIVE-26339 is included only in JIRA. I think the commit message should > start with HIVE-26047 > - HIVE-26047 is included only in the git history. I think it's been merged > as HIVE-26339, and HIVE-26047 can be voided > - HIVE-28155, HIVE-28157, HIVE-28159, and HIVE-28160 are included only in > the git history. Maybe, we can add the fix-version > - HIVE-28206 is included only in the git history. I think we can add the > fix-version and close the ticket > > Best regards, > Okumin > > > On Fri, Sep 27, 2024 at 11:26 AM Butao Zhang <butaozha...@163.com> wrote: > >> +1 (non-binding) >> >> I checked: >> [x] Build the 4.0.1 source code successfully: *mvn clean package >> -DskipTests -Pdist -Piceberg -Pitests* >> [x] Deploy binary tar and start the against Hadoop3.3.6 & Tez0.10.4 >> successfully. >> [x] Run some sql test, iceberg table create/insert/delete. >> >> Thanks Zhihua for the release! >> Good luck! >> >> >> Thanks, >> Butao Zhang >> ---- Replied Message ---- >> From Denys Kuzmenko<dkuzme...@apache.org> <undefined> >> Date 9/26/2024 23:41 >> To <dev@hive.apache.org> <dev@hive.apache.org> >> Subject Re: [VOTE] Apache Hive 4.0.1 Release Candidate 0 >> +1 (Binding) >> >> Thanks Zhihua for driving the release! >> >> 1. Verified the checksums and signatures: ✓ OK >> 2. Initialized the schema for MySQL: ✓ OK >> 3. Validated schema upgrade from 3.1.0 to 4.0.1: ✓ OK >> 4. Deployed the binaries and started HS2 and HMS with Hadoop 3.3.6 and >> Tez 0.10.4: ✓ OK >> 5. Executed Iceberg CRUD test suite: ✓ OK >> >> Regards, >> Denys >> >
