[
https://issues.apache.org/jira/browse/HIVE-2779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203311#comment-13203311
]
Hudson commented on HIVE-2779:
------------------------------
Integrated in Hive-trunk-h0.21 #1247 (See
[https://builds.apache.org/job/Hive-trunk-h0.21/1247/])
HIVE-2779 Improve Hooks run in Driver
(Kevin Wilfong via namit)
namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241729
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java
*
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveSemanticAnalyzerHook.java
*
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveSemanticAnalyzerHookContext.java
*
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveSemanticAnalyzerHookContextImpl.java
*
/hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/hooks/VerifyHooksRunInOrder.java
* /hive/trunk/ql/src/test/queries/clientpositive/hook_order.q
* /hive/trunk/ql/src/test/results/clientnegative/bad_exec_hooks.q.out
* /hive/trunk/ql/src/test/results/clientpositive/hook_order.q.out
> Improve hooks run in Driver
> ---------------------------
>
> Key: HIVE-2779
> URL: https://issues.apache.org/jira/browse/HIVE-2779
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2779.D1599.1.patch, HIVE-2779.D1599.2.patch,
> HIVE-2779.D1599.3.patch
>
>
> There are some small improvements that can be made to the hooks which are run
> in the Driver:
> 1) The code to get hooks has been clearly just been copy+pasted for each of
> Pre/Post/OnFailure/SemanticAnalyzer hooks. This code should be consolidated
> into a single method.
> 2) There is a lot more information available to SemanticAnalyzer hooks which
> ran after semantic analysis than to those that run before, such as inputs and
> outputs. We should make some of this information available to those hooks,
> preferably through HiveSemanticAnalyzerHookContext, so that existing hooks
> aren't broken.
> 3) Currently, possibly unintentionally, hooks are initialized and run in the
> order they appear in the comma separated list that is the value of the
> configuration variable. This is a useful property, we should add comments
> indicating this is desired and add a unit test to enforce it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
