[ https://issues.apache.org/jira/browse/HIVE-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220504#comment-13220504 ]
Phabricator commented on HIVE-2810: ----------------------------------- cwsteinbach has commented on the revision "HIVE-2810 [jira] Implement NULL-safe equality operator <=>". INLINE COMMENTS ql/src/test/queries/clientpositive/udf_equal.q:7 Please add NULL comparisons for '=': NULL=NULL true=NULL NULL=true false=NULL NULL=false ql/src/test/queries/clientpositive/udf_equal.q:12 Please add the missing comparisons from above that were used to test '='. I realize that '<=>' is implemented in terms of '=', but the tests should treat both implementations like black boxes. Thanks. REVISION DETAIL https://reviews.facebook.net/D1791 BRANCH DPAL-843 > Implement NULL-safe equality operator <=> > ----------------------------------------- > > Key: HIVE-2810 > URL: https://issues.apache.org/jira/browse/HIVE-2810 > Project: Hive > Issue Type: New Feature > Components: Query Processor, UDF > Affects Versions: 0.9.0 > Reporter: Carl Steinbach > Assignee: Navis > Fix For: 0.9.0 > > Attachments: HIVE-2810.D1791.1.patch, HIVE-2810.D1791.2.patch, > HIVE-2810.D1791.3.patch > > > Ref: > http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html#operator_equal-to -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira