[ https://issues.apache.org/jira/browse/HIVE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225400#comment-13225400 ]
Namit Jain commented on HIVE-2838: ---------------------------------- There is a lot of common stuff between ReadEntity and WriteEntity - table, partition, type etc. If you look at the code, it is ~80% same. Chances are the custom hooks that you are writing for processing readEntity and writeEntity are similar, and are duplicating a lot of logic. I was proposing the following: Common Class (Entity) Both ReadEntity and WriteEntity extend Entity. Nothing needs to be changed for existing hooks. > cleanup readentity/writeentity > ------------------------------ > > Key: HIVE-2838 > URL: https://issues.apache.org/jira/browse/HIVE-2838 > Project: Hive > Issue Type: Bug > Reporter: Namit Jain > Assignee: Namit Jain > > Ideally, there should be one common entity instead of readentity/writeentity. > Unfortunately, that would be a backward incompatible change since users os > hive might have written > there own hooks, where they are using readentity/writeentity. > We should atleast create a common class, and then we can deprecate read/write > entity later, for a new release. > For now, I propose to make a backward compatible change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira