[ https://issues.apache.org/jira/browse/HIVE-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225502#comment-13225502 ]
Phabricator commented on HIVE-2646: ----------------------------------- cwsteinbach has requested changes to the revision "HIVE-2646 [jira] Hive Ivy dependencies on Hadoop should depend on jars directly, not tarballs". INLINE COMMENTS build-common.xml:68 Please move this to build.properties build-common.xml:86 Is this specific to 0.23? If so please add a comment. build-common.xml:148 Since Hadoop 1.0.0 is now a reality, I think it would be good to always prefix any occurrences of version numbers with the major number, e.g. "0.20" instead of "20" build-common.xml:154 We should be consistent about the naming scheme in relation to versions, e.g. "ivy-retrieve-hadoop-0.20", "ivy-resolve-hadoop-0.20", "hadoop-0.20-shim", etc. build.properties:20 Please add some comments explaining what this property does. testutils/hadoop:48 We should probably just insist that $HIVE_TEST_CLASSPATH is set and error out if it isn't. build.xml:700 This target is broken. build.xml:740 This target is broken. REVISION DETAIL https://reviews.facebook.net/D2133 BRANCH HIVE-2646-dev-branch > Hive Ivy dependencies on Hadoop should depend on jars directly, not tarballs > ---------------------------------------------------------------------------- > > Key: HIVE-2646 > URL: https://issues.apache.org/jira/browse/HIVE-2646 > Project: Hive > Issue Type: Bug > Components: Build Infrastructure > Affects Versions: 0.8.0 > Reporter: Andrew Bayer > Priority: Critical > Attachments: HIVE-2646.D2133.1.patch, HIVE-2646.D2133.2.patch, > HIVE-2646.D2133.3.patch, HIVE-2646.diff.txt > > > The current Hive Ivy dependency logic for its Hadoop dependencies is > problematic - depending on the tarball and extracting the jars from there, > rather than depending on the jars directly. It'd be great if this was fixed > to actually have the jar dependencies defined directly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira