[ 
https://issues.apache.org/jira/browse/HIVE-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227046#comment-13227046
 ] 

Phabricator commented on HIVE-2646:
-----------------------------------

thw has commented on the revision "HIVE-2646 [jira] Hive Ivy dependencies on 
Hadoop should depend on jars directly, not tarballs".

  There are several changes to build/dist/lib that may not be intended. In 
particular there should be no hadoop bundled and other versions not downgrade. 
Should review to ensure we don't bundle things that are already part of hadoop 
(such as slf4j etc.)

  ```
  readfactline-lm:hive thw$ ls trunk-before/build/dist/lib/ | sort > oldlib.txt
  readfactline-lm:hive thw$ ls trunk/build/dist/lib/ | sort > newlib.txt
  readfactline-lm:hive thw$ diff oldlib.txt newlib.txt
  8,9d7
  < commons-beanutils-1.7.0.jar
  < commons-beanutils-core-1.8.0.jar
  12d9
  < commons-codec-1.4.jar
  14d10
  < commons-configuration-1.6.jar
  16d11
  < commons-digester-1.8.jar
  19a15
  > commons-lang-2.5.jar
  23d18
  < commons-math-2.1.jar
  31a27,29
  > ftplet-api-1.0.0.jar
  > ftpserver-core-1.0.0.jar
  > ftpserver-deprecated-1.0.0-M2.jar
  32a31,33
  > hadoop-core-0.20.2.jar
  > hadoop-test-0.20.2.jar
  > hadoop-tools-0.20.2.jar
  52,53c53,54
  < jackson-core-asl-1.0.1.jar
  < jackson-mapper-asl-1.0.1.jar
  ---
  > httpclient-4.0.1.jar
  > httpcore-4.0.1.jar
  58,59c59,60
  < jetty-6.1.26.jar
  < jetty-util-6.1.26.jar
  ---
  > jetty-6.1.14.jar
  > jetty-util-6.1.14.jar
  64d64
  < junit-3.8.1.jar
  65a66
  > junit-4.5.jar
  71a73
  > mina-core-2.0.0-M5.jar
  76d77
  < servlet-api-2.5-20081211.jar
  77a79,80
  > servlet-api-2.5.jar
  > slf4j-api-1.5.2.jar
  ```

REVISION DETAIL
  https://reviews.facebook.net/D2133

                
> Hive Ivy dependencies on Hadoop should depend on jars directly, not tarballs
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-2646
>                 URL: https://issues.apache.org/jira/browse/HIVE-2646
>             Project: Hive
>          Issue Type: Bug
>          Components: Build Infrastructure
>    Affects Versions: 0.8.0
>            Reporter: Andrew Bayer
>            Priority: Critical
>         Attachments: HIVE-2646.D2133.1.patch, HIVE-2646.D2133.2.patch, 
> HIVE-2646.D2133.3.patch, HIVE-2646.D2133.4.patch, HIVE-2646.D2133.5.patch, 
> HIVE-2646.D2133.6.patch, HIVE-2646.diff.txt
>
>
> The current Hive Ivy dependency logic for its Hadoop dependencies is 
> problematic - depending on the tarball and extracting the jars from there, 
> rather than depending on the jars directly. It'd be great if this was fixed 
> to actually have the jar dependencies defined directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to