[
https://issues.apache.org/jira/browse/HIVE-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238791#comment-13238791
]
Phabricator commented on HIVE-2907:
-----------------------------------
kevinwilfong has commented on the revision "HIVE-2907 [jira] Hive error when
dropping a table with large number of partitions".
This looks really good, thanks for the code clean up, just some small
comments.
INLINE COMMENTS
metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java:164
It'd be great if we could use the same config here, otherwise alter table will
face the same memory issues for tables with lots of partitions.
This could be a separate task too.
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java:1399-1401
If any client code already assumes that if 0 is max, it returns all partitions,
which, given the code in HiveAlterHandler, seems possible, this will break that
code. Could we treat 0 as infinity as well?
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java:1565-1567
Same here regarding 0 => infinity
metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java:1997
Can you remove this line if it's not needed.
metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java:544
Shouldn't this be "table should not have existed"
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:292 Could you add a
testcase, where you set this really low, e.g. 1, and you drop a table with
multiple partitions.
Also, could you add a similar test where you make one of the partitions
NO_DROP, and make sure it fails.
REVISION DETAIL
https://reviews.facebook.net/D2505
> Hive error when dropping a table with large number of partitions
> ----------------------------------------------------------------
>
> Key: HIVE-2907
> URL: https://issues.apache.org/jira/browse/HIVE-2907
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.9.0
> Environment: General. Hive Metastore bug.
> Reporter: Mousom Dhar Gupta
> Priority: Minor
> Fix For: 0.9.0
>
> Attachments: HIVE-2907.1.patch.txt, HIVE-2907.D2505.1.patch
>
> Original Estimate: 10h
> Remaining Estimate: 10h
>
> Running into an "Out Of Memory" error when trying to drop a table with 128K
> partitions.
> The methods dropTable in
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
> and dropTable in ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
> encounter out of memory errors
> when dropping tables with lots of partitions because they try to load the
> metadata for every partition into memory.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
