[ https://issues.apache.org/jira/browse/HIVE-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244556#comment-13244556 ]
Phabricator commented on HIVE-2822: ----------------------------------- ashutoshc has requested changes to the revision "HIVE-2822 [jira] Add JSON output to the hive ddl commands". Seems like output in *.q.out has changed in unintended ways. INLINE COMMENTS common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:560 This also needs to be added in file conf/hive-default.xml.template This template file is not used anywhere but exists for documentation purposes. ql/src/test/results/clientnegative/column_rename1.q.out:26 This line is certainly useful and should appear in the output. After the change it seems it will get lost. ql/src/test/results/clientnegative/column_rename4.q.out:26 Here also, column does not exist is useful bit of error message, which is not there anymore in patched version. ql/src/test/results/clientnegative/database_create_already_exists.q.out:14 Here, it seems wrong error message got generated. This will confuse users. ql/src/test/results/clientnegative/database_drop_does_not_exist.q.out:9 Same as above. REVISION DETAIL https://reviews.facebook.net/D2475 BRANCH HIVE-2822-dev-branch > Add JSON output to the hive ddl commands > ---------------------------------------- > > Key: HIVE-2822 > URL: https://issues.apache.org/jira/browse/HIVE-2822 > Project: Hive > Issue Type: Improvement > Reporter: Chris Dean > Assignee: Chris Dean > Attachments: HIVE-2822.03-branch0-8.patch, HIVE-2822.03.patch, > HIVE-2822.03b.patch, HIVE-2822.04-branch-08.patch, > HIVE-2822.05-branch0-8-1.patch, HIVE-2822.05-branch0-8.patch, > HIVE-2822.05.patch, HIVE-2822.D2475.1.patch, HIVE-2822.D2475.2.patch, > hive-json-01-branch0-8.patch, hive-json-01.patch, > hive-json-02-branch0-8.patch, hive-json-02.patch > > > The goal is to have an option to produce JSON output of the DDL commands that > is easily machine parseable. > For example, "desc my_table" currently gives > {noformat} > id bigint > user string > {noformat} > and we want to allow a json output: > {noformat} > { > "columns": [ > {"name": "id", "type": "bigint"}, > {"name": "user", "type": "string"} > ] > } > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira