[
https://issues.apache.org/jira/browse/HIVE-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247852#comment-13247852
]
Phabricator commented on HIVE-2926:
-----------------------------------
cwsteinbach has requested changes to the revision "HIVE-2926 [jira] Expose some
information about the metastore through JMX".
INLINE COMMENTS
common/src/java/org/apache/hadoop/hive/common/HiveVersionAnnotation.java:26
Comment should reference Hive instead of Hadoop. Same thing applies to several
of the comments below.
common/src/java/org/apache/hadoop/hive/common/VersionInfo.java:101 Change to
"Apache Hive"
ql/src/test/results/clientnegative/column_rename1.q.out:26 These q file
updates don't belong here, right?
common/build.xml:30 I think this target should be moved into build-common.xml
and should get called for all sub-projects. This will make it a lot easier to
diagnose cases where people are using JARs from different versions of Hive.
common/src/java/org/apache/hadoop/hive/common/HiveVersionAnnotation.java:50
According to saveVersion.sh this could also return the URL for a Git repo. The
comment should be updated to reflect this, and I think the name of the method
should be changed to "getRepositoryUrl()"
common/src/java/org/apache/hadoop/hive/common/HiveVersionAnnotation.java:55
Ditto.
common/src/java/org/apache/hadoop/hive/common/VersionInfo.java:75 "source
code repository URL"
common/src/java/org/apache/hadoop/hive/common/VersionInfo.java:95 Does it
make sense to reference a revision number without also mentioning the
repository URL?
common/src/java/org/apache/hadoop/hive/common/VersionInfo.java:102 This
references svn. What if this was built using git?
metastore/src/java/org/apache/hadoop/hive/metastore/MXBeanImpl.java:33 This
assumes that VersionInfo.getRevision() returns an SVN revision number.
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:3060
Does it make sense to include minWorkerThreads, or the value of
hive.metastore.uris? What about the value of useSasl or tcpKeepAlive?
REVISION DETAIL
https://reviews.facebook.net/D2637
BRANCH
HIVE-2926-branch
> Expose some information about the metastore through JMX
> -------------------------------------------------------
>
> Key: HIVE-2926
> URL: https://issues.apache.org/jira/browse/HIVE-2926
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.9.0
>
> Attachments: HIVE-2926.D2637.1.patch, hive-2926.1.patch,
> metastore-jmx.patch
>
>
> Expose some information about the metastore through JMX
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
