[
https://issues.apache.org/jira/browse/HIVE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265201#comment-13265201
]
Phabricator commented on HIVE-2655:
-----------------------------------
cwsteinbach has requested changes to the revision "HIVE-2655 [jira] Ability to
define functions in HQL".
INLINE COMMENTS
ql/src/test/queries/clientpositive/macro.q:3 The test coverage for this
feature needs to be expanded.
What happens if the macro references a hiveconf or hivevar parameter?
Missing positive coverage for:
* Macro with zero input parameters
* Macro with two input parameters
* EXPLAIN output for a query using each variation of the above.
* EXPLAIN EXTENDED output for a query using each variation of the above.
Negative coverage for:
* macro body references an undefined input parameter
* input parameter not referenced in macro body
* macro that defines two input parameters with the same name
* Defining the same macro twice.
* Droping a macro that doesn't exist.
REVISION DETAIL
https://reviews.facebook.net/D915
BRANCH
macro
> Ability to define functions in HQL
> ----------------------------------
>
> Key: HIVE-2655
> URL: https://issues.apache.org/jira/browse/HIVE-2655
> Project: Hive
> Issue Type: New Feature
> Components: SQL
> Reporter: Jonathan Perlow
> Assignee: Jonathan Chang
> Attachments: HIVE-2655.D915.1.patch, HIVE-2655.D915.2.patch,
> HIVE-2655.D915.3.patch, HIVE-2655.D915.4.patch
>
>
> Ability to create functions in HQL as a substitute for creating them in Java.
> Jonathan Chang requested I create this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
