[ 
https://issues.apache.org/jira/browse/HIVE-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268619#comment-13268619
 ] 

Carl Steinbach commented on HIVE-895:
-------------------------------------

bq. One thing of concern is that the avroserde relies on the ql package, which 
required a change to the build script to build serde afterwards. Is there a 
defined dependency for Hive's modules, and if so does this break that? If so, 
the other option would be to move this to the contrib package, but to me 
contrib is a dirty word and I'd like to avoid that.

Right now ql depends on serde, but not vice-versa, so it sounds like this patch 
will add a circular dependency which is something we should probably try to 
avoid. I also agree with you that this belongs in the serde package as opposed 
to contrib. Do you think it's possible to move the ql code that the avro serde 
depends on to common?

Also, I apologize in advance for this request, but would you mind posting a 
review for this on phabricator? Directions are located here:
https://cwiki.apache.org/Hive/phabricatorcodereview.html

If this looks like too much of I pain I can post the review request for you, 
but I may need some help applying the patch to trunk.

Thanks!

                
> Add SerDe for Avro serialized data
> ----------------------------------
>
>                 Key: HIVE-895
>                 URL: https://issues.apache.org/jira/browse/HIVE-895
>             Project: Hive
>          Issue Type: New Feature
>          Components: Serializers/Deserializers
>            Reporter: Jeff Hammerbacher
>            Assignee: Jakob Homan
>         Attachments: HIVE-895-draft.patch
>
>
> As Avro continues to mature, having a SerDe to allow HiveQL queries over Avro 
> data seems like a solid win.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to