[ https://issues.apache.org/jira/browse/HIVE-3048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401893#comment-13401893 ]
Hudson commented on HIVE-3048: ------------------------------ Integrated in Hive-trunk-h0.21 #1515 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1515/]) HIVE-3048 : Collect_set Aggregate does uneccesary check for value. (Ed Capriolo via Ashutosh Chauhan) (Revision 1354079) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1354079 Files : * /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCollectSet.java > Collect_set Aggregate does uneccesary check for value. > ------------------------------------------------------ > > Key: HIVE-3048 > URL: https://issues.apache.org/jira/browse/HIVE-3048 > Project: Hive > Issue Type: Improvement > Affects Versions: 0.8.1 > Reporter: Edward Capriolo > Assignee: Edward Capriolo > Fix For: 0.10.0 > > Attachments: HIVE-3048.patch.1.txt > > > Sets already de-duplicate for free no need for existence check. > {noformat} > private void putIntoSet(Object p, MkArrayAggregationBuffer myagg) { > if (myagg.container.contains(p)) > return; > Object pCopy = ObjectInspectorUtils.copyToStandardObject(p, > this.inputOI); > myagg.container.add(pCopy); > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira