----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5687/#review8776 -----------------------------------------------------------
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java <https://reviews.apache.org/r/5687/#comment18552> Instead of regex, it might be better to use URI to parse the string. String scheme = new Path(value).toURI().getScheme(); return (scheme != null) && !scheme.equalsIgnoreCase("file"); - Ashutosh Chauhan On June 30, 2012, 6:15 p.m., Kanna Karanam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5687/ > ----------------------------------------------------------- > > (Updated June 30, 2012, 6:15 p.m.) > > > Review request for hive, Carl Steinbach, Edward Capriolo, and Ashutosh > Chauhan. > > > Description > ------- > > Instead of restricting resources download to "s3", "s3n", "hdfs" make it open > for any external file systems. > > > This addresses bug HIVE-3146. > https://issues.apache.org/jira/browse/HIVE-3146 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 1355510 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java > 1355510 > > Diff: https://reviews.apache.org/r/5687/diff/ > > > Testing > ------- > > Yes. All unit tests passed. > > > Thanks, > > Kanna Karanam > >
