----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5777/#review9021 -----------------------------------------------------------
Ship it! Ship It! http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java <https://reviews.apache.org/r/5777/#comment19184> path here is used to construct URI object later. URI constructor javadocs says that path should either begin with '/' or should be empty, irrespective of OS. So, looks like check for path.startsWith('/') makes most sense here. As Kanna noted his changes make path to /D:/hive/etc from D:/hive/etc thus making URI constructor happy. - Ashutosh Chauhan On July 5, 2012, 7:50 p.m., Kanna Karanam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5777/ > ----------------------------------------------------------- > > (Updated July 5, 2012, 7:50 p.m.) > > > Review request for hive, Carl Steinbach, Edward Capriolo, and Ashutosh > Chauhan. > > > Description > ------- > > 1) Not closing the file handle EximUtil after reading the metadata from the > file. > 2) Nit: Get the path from URI to handle the Windows paths. > > > This addresses bug HIVE-3232. > https://issues.apache.org/jira/browse/HIVE-3232 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java > 1357818 > > Diff: https://reviews.apache.org/r/5777/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Kanna Karanam > >
