----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6214/ -----------------------------------------------------------
Review request for hive, Carl Steinbach, Edward Capriolo, and Ashutosh Chauhan. Description ------- TestHiveConf : Location of the “hive-site.xml” path on Unix is different from Windows so need to compare the paths after generating the OS independent URI path. TestHiveHistory: Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows TestExecDriver: 1) Generate the testFileDirectory from URI object instead of manually constructing it to make it work on Unix as well as on Windows2) change the absolute path to relative path of the “Cat” utility to make it work on windows with CygWin tools in the Windows Path. This addresses bug HIVe-3319. https://issues.apache.org/jira/browse/HIVe-3319 Diffs ----- trunk/common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java 1367127 trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 1367127 trunk/ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 1367127 Diff: https://reviews.apache.org/r/6214/diff/ Testing ------- Yes Thanks, Kanna Karanam