[ https://issues.apache.org/jira/browse/HIVE-3394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437265#comment-13437265 ]
Gang Tim Liu commented on HIVE-3394: ------------------------------------ @Carl: thank you for giving me the opportunities to work on it. Initially have natural resistance due to work plan but quickly realize it is good thing to do and will make HIVE better which is my goal. I enjoy this refactor with them in mind. have a good weekend. > Refactor a few classes' constructors with creational patterns > ------------------------------------------------------------- > > Key: HIVE-3394 > URL: https://issues.apache.org/jira/browse/HIVE-3394 > Project: Hive > Issue Type: Bug > Reporter: Gang Tim Liu > Assignee: Gang Tim Liu > Priority: Minor > Attachments: HIVE-3394.patch.1 > > > It's good to refactor the following classes' constructors with > builder/factory pattern. This should be done before HIVE-3072 so that > HIVE-3072 can refresh according and extend it to skewed use case: > 1. MStorageDescriptor.java > 2. ColumnInfo.java > 3. ParseContext.java > 4. CreateTableDesc.java > 5. ExprNodeColumnDesc.java -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira