----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/#review10629 -----------------------------------------------------------
TestHiveMetaTool.launch <https://reviews.apache.org/r/6650/#comment22730> Thanks Namit. My bad. I'll fix this. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java <https://reviews.apache.org/r/6650/#comment22729> The reason behind adding these methods to the ObjectStore class is as follows. HiveMetaTool accesses the metastore through JDO and DN. I think the JDO and the metastore access logic should reside in ObjectStore; it doesn't seem to make a lot of sense to duplicate this logic elsewhere, for instance in the HiveMetaTool. Hence we decided to add the methods to ObjectStore. While the other ObjectStore methods that access the metastore are exposed via Thrift, HiveMetaTool is yet another way to expose them. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java <https://reviews.apache.org/r/6650/#comment22731> The reason behind adding these methods to ObjectStore is as follows. HiveMetaTool accesses the metastore through JDO and DN. ObjectStore seems like the place for all JDO and metastore access logic to reside. To me it doesn't make a lot of sense to duplicate this code elsewhere say for instance in the HiveMetaTool. While most of the ObjectStore methods are exposed via Thrift, I think of HiveMetaTool as yet another way to expose some of the ObjectStore methods. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java <https://reviews.apache.org/r/6650/#comment22749> Please let me know what the alternative is. - Shreepadma Venugopalan On Aug. 22, 2012, 2:48 a.m., Shreepadma Venugopalan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6650/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2012, 2:48 a.m.) > > > Review request for hive and Carl Steinbach. > > > Description > ------- > > This patch implement hive metatool which, > > * lets admins perform a HA upgrade by patching the location of the NN in > Hive's metastore > * allows JDOQL to be executed against the metastore. > > Additionally this patch also upgrades DN to 3.0 > > > This addresses bug HIVE-3056. > https://issues.apache.org/jira/browse/HIVE-3056 > > > Diffs > ----- > > TestHiveMetaTool.launch PRE-CREATION > bin/ext/metatool.sh PRE-CREATION > bin/metatool PRE-CREATION > build.xml 6712af9 > conf/hive-default.xml.template cc1565f > metastore/ivy.xml 3011d2f > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 6f4716c > metastore/src/java/org/apache/hadoop/hive/metastore/tools/HiveMetaTool.java > PRE-CREATION > metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaTool.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/6650/diff/ > > > Testing > ------- > > Manual testing for various metatool options. > > > Thanks, > > Shreepadma Venugopalan > >
