[ 
https://issues.apache.org/jira/browse/HIVE-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452372#comment-13452372
 ] 

Shreepadma Venugopalan commented on HIVE-3443:
----------------------------------------------

I'm not adding any code that is specific to Haivvreo to Hive, nor is this patch 
supporting the change from Haivvreo to AvroSerde. Note that this tool is 
specifically intended for migration to HA and **not** to support change from 
Haivvreo to AvroSerde. 

This patch makes the metatool more flexible and generic to allow the users to 
update both Haivvreo and AvroSerde specific metadata that resides in the 
metastore. If its not Hive's responsibility to support non-ASF code such as 
Haivvreo, then Haivvreo specific property such as schema.url shouldn't be past 
of the metastore in the first place. Given that it is and users need a way to 
migrate to HA, there is not a better and a convenient way to do this migration 
other than make Metatool flexible enough to take in serdeParamKey from the 
user. This change is fixing what you are specifically objecting to i.e., Hive 
shouldn't know about Haivvreo. With this patch, Hive Metatool will be oblivious 
to whether its updating Haivvreo or AvroSerde metadata.
                
> Hive Metatool should take serde_param_key from the user to allow for changes 
> to avro serde's schema url key
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-3443
>                 URL: https://issues.apache.org/jira/browse/HIVE-3443
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 0.10.0
>            Reporter: Shreepadma Venugopalan
>            Assignee: Shreepadma Venugopalan
>            Priority: Critical
>         Attachments: HIVE-3443.1.patch.txt
>
>
> Hive Metatool should take serde_param_key from the user to allow for chanes 
> to avro serde's schema url key. In the past "avro.schema.url" key used to be 
> called "schema.url". 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to