----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7221/#review12053 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <https://reviews.apache.org/r/7221/#comment25696> Add lot of comments in this function - when can this function be invoked etc. Please change the name of the function. This looks like a fairly generic function, but it is not. Please add comments to explain what you are trying - namit jain On Sept. 30, 2012, 8:55 p.m., Yin Huai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7221/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2012, 8:55 p.m.) > > > Review request for hive. > > > Description > ------- > > Please see jira for detailed description > > > This addresses bug HIVE-3495. > https://issues.apache.org/jira/browse/HIVE-3495 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 3f2aaaa > ql/src/test/queries/clientpositive/udaf_percentile_approx.q c436a63 > ql/src/test/results/clientpositive/count.q.out 61e54c7 > ql/src/test/results/clientpositive/nullgroup.q.out 434fa6c > ql/src/test/results/clientpositive/nullgroup2.q.out aa52d62 > ql/src/test/results/clientpositive/nullgroup4.q.out 3dd3c66 > ql/src/test/results/clientpositive/nullgroup4_multi_distinct.q.out 9ac4bbc > ql/src/test/results/clientpositive/udaf_percentile_approx.q.out 4f85a82 > > Diff: https://reviews.apache.org/r/7221/diff/ > > > Testing > ------- > > All tests pass. > > > Thanks, > > Yin Huai > >
