[ 
https://issues.apache.org/jira/browse/HIVE-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-3617:
------------------------------

    Attachment: HIVE-3617.D6183.1.patch

navis requested code review of "HIVE-3617 [jira] Predicates pushed down to 
hbase is not handled properly when constant part is shown first".
Reviewers: JIRA

  DPAL-1922 Predicates pushed down to hbase is not handled properly when 
constant part is shown first

  Test result could not show the difference because predicates pushed down are 
not removed currently(HIVE-2897). So I added log message(scan.toMap()) and 
checked the output.

  with query
  select * from hbase_ppd_keyrange where key > 8 and key < 21;
  timeRange=[0, 9223372036854775807], batch=-1, startRow=\x00\x00\x00\x08\x00, 
stopRow=\x00\x00\x00\x15, ...

  but with query
  select * from hbase_ppd_keyrange where 8 < key and key < 21;
  timeRange=[0, 9223372036854775807], batch=-1, startRow=, 
stopRow=\x00\x00\x00\x15, ...

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D6183

AFFECTED FILES
  
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java
  ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java
  ql/src/java/org/apache/hadoop/hive/ql/index/IndexSearchCondition.java
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/14763/

To: JIRA, navis

                
> Predicates pushed down to hbase is not handled properly when constant part is 
> shown first
> -----------------------------------------------------------------------------------------
>
>                 Key: HIVE-3617
>                 URL: https://issues.apache.org/jira/browse/HIVE-3617
>             Project: Hive
>          Issue Type: Bug
>          Components: HBase Handler
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Minor
>         Attachments: HIVE-3617.D6183.1.patch
>
>
> Test result could not show the difference because predicates pushed down are 
> not removed currently(HIVE-2897). So I added log message(scan.toMap()) and 
> checked the output.
> with query
> select * from hbase_ppd_keyrange where key > 8 and key < 21;
> timeRange=[0, 9223372036854775807], batch=-1, startRow=\x00\x00\x00\x08\x00, 
> stopRow=\x00\x00\x00\x15, ...
> but with query
> select * from hbase_ppd_keyrange where 8 < key and key < 21;
> timeRange=[0, 9223372036854775807], batch=-1, startRow=, 
> stopRow=\x00\x00\x00\x15, ...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to