[ https://issues.apache.org/jira/browse/HIVE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485871#comment-13485871 ]
Phabricator commented on HIVE-3570: ----------------------------------- njain has commented on the revision "HIVE-3570 [jira] Hive changes for Optr level stats". INLINE COMMENTS ql/src/test/org/apache/hadoop/hive/ql/hooks/OptrStatGroupByHook.java:1 add apache header ql/src/test/org/apache/hadoop/hive/ql/hooks/OptrStatGroupByHook.java:29 add some comments - what are you trying to do ? ql/src/test/org/apache/hadoop/hive/ql/hooks/OptrStatGroupByHook.java:49 fix lint ql/src/test/queries/clientpositive/OptrStatGroupBy.q:1 add some comments in the test. What are you trying to achieve ? ql/src/test/queries/clientpositive/OptrStatGroupBy.q:1 The test names start with a lower case letter - can you rename this test file ? ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java:997 lint ?? REVISION DETAIL https://reviews.facebook.net/D5985 To: njain, sambavim, kevinwilfong, satadru Cc: JIRA, adobriyal > Add/fix facility to collect operator specific statisticsin hive + add > hash-in/hash-out counter for GroupBy Optr > --------------------------------------------------------------------------------------------------------------- > > Key: HIVE-3570 > URL: https://issues.apache.org/jira/browse/HIVE-3570 > Project: Hive > Issue Type: Improvement > Components: Statistics > Affects Versions: 0.9.0 > Reporter: Satadru Pan > Assignee: Satadru Pan > Priority: Minor > Attachments: HIVE-3570.1.patch.txt, HIVE-3570.D5985.1.patch, > HIVE-3570.D5985.2.patch, HIVE-3570.D5985.3.patch, HIVE-3570.D5985.4.patch, > HIVE-3570.D5985.5.patch > > > Requirement: Collect Operator specific stats for hive queries. Use the > counter framework available in Hive Operator.java to accomplish that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira