----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7941/#review13461 -----------------------------------------------------------
trunk/metastore/scripts/upgrade/mysql/upgrade-0.9.0-to-0.10.0.mysql.sql <https://reviews.apache.org/r/7941/#comment28833> Are the prefix numbers there to keep things sorted in the upgrade/<database> directory? If so, (I am being nitpicky) why use 12 instead of 11? Moreover, you are using 011 as prefix in oracle directory while 012 in mysql. Should we try to be consistent? trunk/metastore/scripts/upgrade/oracle/upgrate-0.9.0-to-0.10.0.oracle.sql <https://reviews.apache.org/r/7941/#comment28834> Fix filename to have upgrade (instead of upgrade):-) trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java <https://reviews.apache.org/r/7941/#comment28835> Nitpicky: The same code to query for the token appears in addToken(), removeToken(), getToken(). Should we consider refactoring it? trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java <https://reviews.apache.org/r/7941/#comment28836> Any particular reason why this is not abstract as well? - Mark Grover On Nov. 13, 2012, 8:45 a.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7941/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2012, 8:45 a.m.) > > > Review request for hive and Carl Steinbach. > > > Description > ------- > > DB based token store > > > This addresses bug HIVE-3255. > https://issues.apache.org/jira/browse/HIVE-3255 > > > Diffs > ----- > > trunk/metastore/scripts/upgrade/derby/012-HIVE-3255.derby.sql PRE-CREATION > trunk/metastore/scripts/upgrade/derby/upgrade-0.9.0-to-0.10.0.derby.sql > 1408480 > trunk/metastore/scripts/upgrade/mysql/012-HIVE-3255.mysql.sql PRE-CREATION > trunk/metastore/scripts/upgrade/mysql/upgrade-0.9.0-to-0.10.0.mysql.sql > 1408480 > trunk/metastore/scripts/upgrade/oracle/012-HIVE-3255.oracle.sql > PRE-CREATION > trunk/metastore/scripts/upgrade/oracle/upgrate-0.9.0-to-0.10.0.oracle.sql > PRE-CREATION > trunk/metastore/scripts/upgrade/postgres/012-HIVE-3255.postgres.sql > PRE-CREATION > > trunk/metastore/scripts/upgrade/postgres/upgrade-0.9.0-to-0.10.0.postgres.sql > 1408480 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 1408480 > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 1408480 > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java > 1408480 > > trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MDelegationToken.java > PRE-CREATION > > trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MMasterKey.java > PRE-CREATION > trunk/metastore/src/model/package.jdo 1408480 > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 1408480 > > trunk/shims/src/common-secure/java/org/apache/hadoop/hive/thrift/DBTokenStore.java > PRE-CREATION > > trunk/shims/src/common-secure/java/org/apache/hadoop/hive/thrift/DelegationTokenStore.java > 1408480 > > trunk/shims/src/common-secure/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java > 1408480 > > trunk/shims/src/common-secure/java/org/apache/hadoop/hive/thrift/MemoryTokenStore.java > 1408480 > > trunk/shims/src/common-secure/java/org/apache/hadoop/hive/thrift/ZooKeeperTokenStore.java > 1408480 > > trunk/shims/src/common-secure/test/org/apache/hadoop/hive/thrift/TestDBTokenStore.java > PRE-CREATION > > trunk/shims/src/common/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java > 1408480 > > Diff: https://reviews.apache.org/r/7941/diff/ > > > Testing > ------- > > Includes unit test > > > Thanks, > > Ashutosh Chauhan > >
