[
https://issues.apache.org/jira/browse/HIVE-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502613#comment-13502613
]
Namit Jain commented on HIVE-2935:
----------------------------------
I haven't looked at the patch either, and I agree with Ashutosh, that additive
portions (like beeline) can be checked in.
However, would it be possible for you to break this patch, and extract the
changes that you have made to the current hive code.
That presents a huge risk, and should be reviewed very carefully.
Or, you can take the other approach, which is to check in the new additive
isolated components first (which will not be used), and
then have the code which touches the current hive code in a patch.
If someone is not using the hive server, what are the changes that this patch
brings in ? That definitely needs to be reviewed very thoroughly.
> Implement HiveServer2
> ---------------------
>
> Key: HIVE-2935
> URL: https://issues.apache.org/jira/browse/HIVE-2935
> Project: Hive
> Issue Type: New Feature
> Components: Server Infrastructure
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Labels: HiveServer2
> Attachments: beelinepositive.tar.gz, HIVE-2935.1.notest.patch.txt,
> HIVE-2935.2.notest.patch.txt, HIVE-2935.2.nothrift.patch.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
