[
https://issues.apache.org/jira/browse/HIVE-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527710#comment-13527710
]
Phabricator commented on HIVE-3401:
-----------------------------------
njain has commented on the revision "HIVE-3401 [jira] Diversify grammar for
split sampling".
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:532 assert
TOK_LENGTH
ql/src/test/queries/clientpositive/split_sample.q:95 can you change ROW to
ROWS
ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java:46 some
comments would really help.
This is not for limit processing, but for sampling - please add a simple query
in the comments where this would be valid
REVISION DETAIL
https://reviews.facebook.net/D4821
To: JIRA, navis
Cc: njain
> Diversify grammar for split sampling
> ------------------------------------
>
> Key: HIVE-3401
> URL: https://issues.apache.org/jira/browse/HIVE-3401
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Navis
> Assignee: Navis
> Priority: Trivial
> Attachments: HIVE-3401.D4821.2.patch, HIVE-3401.D4821.3.patch,
> HIVE-3401.D4821.4.patch, HIVE-3401.D4821.5.patch, HIVE-3401.D4821.6.patch
>
>
> Current split sampling only supports grammar like TABLESAMPLE(n PERCENT). But
> some users wants to specify just the size of input. It can be easily
> calculated with a few commands but it seemed good to support more grammars
> something like TABLESAMPLE(500M).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
