Cheng Hao created HIVE-3816:
-------------------------------

             Summary: Typo in the MapRedTask? Which may affect the debugging 
purpose with IDE.
                 Key: HIVE-3816
                 URL: https://issues.apache.org/jira/browse/HIVE-3816
             Project: Hive
          Issue Type: Bug
          Components: CLI
    Affects Versions: 0.9.1
            Reporter: Cheng Hao
            Priority: Trivial
             Fix For: 0.9.1


There may be a typo in the java file

{code:title=org.apache.hadoop.hive.ql.exec.MapRedTask|borderStyle=solid}
      // Origin: here may have a typo?
   // runningViaChild = ShimLoader.getHadoopShims().isLocalMode(conf) ||
   //   conf.getBoolVar(HiveConf.ConfVars.SUBMITVIACHILD);
      // New: should be the "!"
      runningViaChild = !ShimLoader.getHadoopShims().isLocalMode(conf) ||
        conf.getBoolVar(HiveConf.ConfVars.SUBMITVIACHILD);

      if(!runningViaChild) {
        // we are not running this mapred task via child jvm
        // so directly invoke ExecDriver
        return super.execute(driverContext);
      }
{code} 

Per my understanding, there would be 3 cases:
1) Run the job in a NEW Child process(maybe pseudo hadoop mode) in the same node
mapred.job.tracker=local
hive.exec.submitviachild=true

2) Run the job in the same process in the same node (very helpful in debugging)
mapred.job.tracker=local
hive.exec.submitviachild=false

3) Run the job in a real Hadoop Cluster specified
mapred.job.tracker!=local
hive.exec.submitviachild=true/false

The typo may cause the second case NEVER happens, which we need in developing 
(debugging);

Sorry, not sure if I understand that correctly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to