[ 
https://issues.apache.org/jira/browse/HIVE-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536389#comment-13536389
 ] 

Gunther Hagleitner commented on HIVE-2693:
------------------------------------------

Mark,

If the conversion code goes through double -> String -> BigDecimal, I think 
it's basically rounding the result of the operation. You can achieve the same 
by setting the MathContext in the BigDecimal. That might seem better, but still 
causes issues. For instance: 
BigDecimal(Double.parseDouble(String.valueOf("0.99999999999999999")) = 1.0 and 
BigDecimal("0.99999999999999999") = 0.99999999999999999.

Maybe documenting that we're rounding to a specific precision is the way 
forward, but I still think that not implicitly casting + error is the safer 
choice.

Thoughts?
                
> Add DECIMAL data type
> ---------------------
>
>                 Key: HIVE-2693
>                 URL: https://issues.apache.org/jira/browse/HIVE-2693
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor, Types
>    Affects Versions: 0.10.0
>            Reporter: Carl Steinbach
>            Assignee: Prasad Mujumdar
>         Attachments: 2693_7.patch, 2693_8.patch, 2693_fix_all_tests1.patch, 
> HIVE-2693-10.patch, HIVE-2693-11.patch, HIVE-2693-12-SortableSerDe.patch, 
> HIVE-2693-13.patch, HIVE-2693-14.patch, HIVE-2693-15.patch, 
> HIVE-2693-1.patch.txt, HIVE-2693-all.patch, HIVE-2693-fix.patch, 
> HIVE-2693.patch, HIVE-2693-take3.patch, HIVE-2693-take4.patch
>
>
> Add support for the DECIMAL data type. HIVE-2272 (TIMESTAMP) provides a nice 
> template for how to do this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to