[ 
https://issues.apache.org/jira/browse/HIVE-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-2693:
------------------------------

    Attachment: HIVE-2693.D7683.1.patch

hagleitn requested code review of "HIVE-2693 [jira] Add DECIMAL data type".
Reviewers: JIRA

  HIVE-2693: Add DECIMAL data type

  Add support for the DECIMAL data type. HIVE-2272 (TIMESTAMP) provides a nice 
template for how to do this.

TEST PLAN
  New tests decimal_1.q, decimal_2.q, decimal_3.q (Casts, udfs, joins, 
aggregates, order/sort, etc)
  Decimal has been added to SerDe test classes (TestBinarySortable, etc)
  Decimal has been added to UDF test files
  Decimal has been added to jdbc test file

REVISION DETAIL
  https://reviews.facebook.net/D7683

AFFECTED FILES
  data/files/datatypes.txt
  data/files/kv7.txt
  jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java
  jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveResultSetMetaData.java
  jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcColumn.java
  jdbc/src/java/org/apache/hadoop/hive/jdbc/Utils.java
  jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
  ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFAbs.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericUnaryOp.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFCeil.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFFloor.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPNegative.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPositive.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPower.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRound.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToByte.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToDouble.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToFloat.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToLong.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCorrelation.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCovariance.java
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCovarianceSample.java
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFHistogramNumeric.java
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileApprox.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStd.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStdSample.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVariance.java
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFVarianceSample.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToDecimal.java
  ql/src/test/queries/clientpositive/decimal_1.q
  ql/src/test/queries/clientpositive/decimal_2.q
  ql/src/test/queries/clientpositive/decimal_3.q
  ql/src/test/queries/clientpositive/udf7.q
  ql/src/test/results/clientnegative/invalid_cast_from_binary_1.q.out
  ql/src/test/results/clientnegative/invalid_cast_from_binary_2.q.out
  ql/src/test/results/clientnegative/invalid_cast_from_binary_3.q.out
  ql/src/test/results/clientnegative/invalid_cast_from_binary_4.q.out
  ql/src/test/results/clientnegative/invalid_cast_from_binary_5.q.out
  ql/src/test/results/clientnegative/invalid_cast_from_binary_6.q.out
  ql/src/test/results/clientnegative/wrong_column_type.q.out
  ql/src/test/results/clientpositive/decimal_1.q.out
  ql/src/test/results/clientpositive/decimal_2.q.out
  ql/src/test/results/clientpositive/decimal_3.q.out
  ql/src/test/results/clientpositive/udf7.q.out
  serde/if/serde.thrift
  serde/src/gen/thrift/gen-cpp/serde_constants.cpp
  serde/src/gen/thrift/gen-cpp/serde_constants.h
  
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java
  serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php
  serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py
  serde/src/gen/thrift/gen-rb/serde_constants.rb
  serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
  
serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java
  serde/src/java/org/apache/hadoop/hive/serde2/io/BigDecimalWritable.java
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBigDecimal.java
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java
  
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyBigDecimalObjectInspector.java
  
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
  
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryBigDecimal.java
  
serde/src/test/org/apache/hadoop/hive/serde2/lazybinary/MyTestClassSmaller.java
  serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java
  serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java
  serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/BigDecimalObjectInspector.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaBigDecimalObjectInspector.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableBigDecimalObjectInspector.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableBigDecimalObjectInspector.java
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantBigDecimalObjectInspector.java
  serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java
  serde/src/test/org/apache/hadoop/hive/serde2/TestStatsSerde.java
  serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/MyTestClass.java
  
serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/TestBinarySortableSerDe.java
  serde/src/test/org/apache/hadoop/hive/serde2/lazybinary/MyTestClassBigger.java
  
serde/src/test/org/apache/hadoop/hive/serde2/lazybinary/TestLazyBinarySerDe.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/18435/

To: JIRA, hagleitn
Cc: mgrover

                
> Add DECIMAL data type
> ---------------------
>
>                 Key: HIVE-2693
>                 URL: https://issues.apache.org/jira/browse/HIVE-2693
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor, Types
>    Affects Versions: 0.10.0
>            Reporter: Carl Steinbach
>            Assignee: Prasad Mujumdar
>         Attachments: 2693_7.patch, 2693_8.patch, 2693_fix_all_tests1.patch, 
> HIVE-2693-10.patch, HIVE-2693-11.patch, HIVE-2693-12-SortableSerDe.patch, 
> HIVE-2693-13.patch, HIVE-2693-14.patch, HIVE-2693-15.patch, 
> HIVE-2693-16.patch, HIVE-2693-1.patch.txt, HIVE-2693-all.patch, 
> HIVE-2693.D7683.1.patch, HIVE-2693-fix.patch, HIVE-2693.patch, 
> HIVE-2693-take3.patch, HIVE-2693-take4.patch
>
>
> Add support for the DECIMAL data type. HIVE-2272 (TIMESTAMP) provides a nice 
> template for how to do this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to