[
https://issues.apache.org/jira/browse/HIVE-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547894#comment-13547894
]
Hudson commented on HIVE-2773:
------------------------------
Integrated in Hive-trunk-hadoop2 #54 (See
[https://builds.apache.org/job/Hive-trunk-hadoop2/54/])
HIVE-2773: HiveStorageHandler.configureTableJobProperites() should let the
handler know wether it is configuration for input or output (Francis Liu via
Ashutosh Chauhan) (Revision 1304167)
Result = ABORTED
hashutosh :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304167
Files :
*
/hive/trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java
*
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/DefaultStorageHandler.java
*
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/MapredLocalWork.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/PartitionDesc.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java
> HiveStorageHandler.configureTableJobProperites() should let the handler know
> wether it is configuration for input or output
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-2773
> URL: https://issues.apache.org/jira/browse/HIVE-2773
> Project: Hive
> Issue Type: Improvement
> Reporter: Francis Liu
> Assignee: Francis Liu
> Labels: hcatalog, storage_handler
> Fix For: 0.9.0
>
> Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2773.D1815.1.patch,
> ASF.LICENSE.NOT.GRANTED--HIVE-2773.D2007.1.patch,
> ASF.LICENSE.NOT.GRANTED--HIVE-2773.D2415.1.patch, HIVE-2773.patch
>
>
> HiveStorageHandler.configureTableJobProperties() is called to allow the
> storage handler to setup any properties that the underlying
> inputformat/outputformat/serde may need. But the handler implementation does
> not know whether it is being called for configuring input or output. This
> makes it a problem for handlers which sets an external state. In the case of
> HCatalog's HBase storageHandler, whenever a write needs to be configured we
> create a write transaction which needs to be committed or aborted later on.
> In this case configuring for both input and output each time
> configureTableJobProperties() is called would not be desirable. This has
> become an issue since HCatalog is dropping storageDrivers for SerDe and
> StorageHandler (see HCATALOG-237).
> My proposal is to replace configureTableJobProperties() with two methods:
> configureInputJobProperties()
> configureOutputJobProperties()
> Each method will have the same signature. I cursory look at the code and I
> believe changes should be straighforward also given that we are not really
> changing anything just splitting responsibility. If the community is fine
> with this approach I will go ahead and create a aptch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
