----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9349/#review16246 -----------------------------------------------------------
/trunk/metastore/scripts/upgrade/postgres/011-HIVE-3649.postgres.sql <https://reviews.apache.org/r/9349/#comment34697> I was looking at derby's upgrade script and it seems to be using NOT NULL. Does "NOT NULL" result in a syntax error? If so, perhaps we should add this column without null qualifier and then later set this column as "not null" as listed at http://www.postgresql.org/docs/8.0/static/sql-altertable.html - Mark Grover On Feb. 7, 2013, 2 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9349/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2013, 2 a.m.) > > > Review request for hive. > > > Description > ------- > > I found issues in three files: > > * 010-HIVE-3072.postgres.sql > > Just escaping double quotes were missing. > > * 011-HIVE-3649.postgres.sql > > This alter statement tries to add new "not null" column without any default > value. The statement will fail if the table already contains some data. I've > checked similar script in mysql/ folder and that script is allowing null > values. Thus I've allowed null values also here. > > * 012-HIVE-1362.postgres > > Just syntax fixes. > > > This addresses bug HIVE-3995. > https://issues.apache.org/jira/browse/HIVE-3995 > > > Diffs > ----- > > /trunk/metastore/scripts/upgrade/postgres/010-HIVE-3072.postgres.sql > 1443292 > /trunk/metastore/scripts/upgrade/postgres/011-HIVE-3649.postgres.sql > 1443292 > /trunk/metastore/scripts/upgrade/postgres/012-HIVE-1362.postgres.sql > 1443292 > > Diff: https://reviews.apache.org/r/9349/diff/ > > > Testing > ------- > > I've tested the upgrade scripts by loading file > hive-schema-0.9.0.postgres.sql with some data and executing > upgrade-0.9.0-to-0.10.0.postgres.sql on top of that. > > > Thanks, > > Jarek Cecho > >
