> On Feb. 8, 2013, 3:33 p.m., Mark Grover wrote: > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseRow.java, line > > 127 > > <https://reviews.apache.org/r/5542/diff/1/?file=116176#file116176line127> > > > > Lars, I noticed that the Javadoc here is inconsistent with the method > > signature. This is obviously unrelated to your change but if you have a > > chance, could you please correct the Javadoc here? > > Brock Noland wrote: > Mark, > > I agree we should update the javadoc, however I don't think that should > hold up a commit since it's unrelated to this change and this issue is > critical. That is if Lars doesn't update the patch we can address that issue > in a new JIRA. Would you agree? > > Brock
Fair enough, that's fine by me. - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5542/#review16351 ----------------------------------------------------------- On June 25, 2012, 5:30 a.m., Lars Francke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5542/ > ----------------------------------------------------------- > > (Updated June 25, 2012, 5:30 a.m.) > > > Review request for hive. > > > Description > ------- > > This patch moves the initialization of the fieldsInited variable to the end > of the loop because otherwise NULL values will return stale data on the > second iteration. All other cases should be unaffected by this change. > > > This addresses bug HIVE-3179. > https://issues.apache.org/jira/browse/HIVE-3179 > > > Diffs > ----- > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseRow.java > d35bb52 > > hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestLazyHBaseObject.java > f91be4c > > Diff: https://reviews.apache.org/r/5542/diff/ > > > Testing > ------- > > Debugged problem, added code to existing test to force wrong behavior which > is fixed by this patch, ran the hbase-handler unit tests > > > Thanks, > > Lars Francke > >
