[
https://issues.apache.org/jira/browse/HIVE-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-4016:
------------------------------
Attachment: HIVE-4016.D8547.1.patch
navis requested code review of "HIVE-4016 [jira] Remove init(fname) from
TestParse.vm for each test".
Reviewers: JIRA
HIVE-4016 Remove init(fname) from TestParse.vm for each test
TestParse does not change any of configuration or data, which means calling
init() method before each test is not necessary. After removing it, test time
reduced to 260sec to 16sec.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D8547
AFFECTED FILES
ql/src/test/templates/TestParse.vm
MANAGE HERALD RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/20805/
To: JIRA, navis
> Remove init(fname) from TestParse.vm for each test
> --------------------------------------------------
>
> Key: HIVE-4016
> URL: https://issues.apache.org/jira/browse/HIVE-4016
> Project: Hive
> Issue Type: Improvement
> Components: Testing Infrastructure
> Reporter: Navis
> Assignee: Navis
> Priority: Trivial
> Attachments: HIVE-4016.D8547.1.patch
>
>
> TestParse does not change any of configuration or data, which means calling
> init() method before each test is not necessary. After removing it, test time
> reduced to 260sec to 16sec.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
