[
https://issues.apache.org/jira/browse/HIVE-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580388#comment-13580388
]
Phabricator commented on HIVE-4016:
-----------------------------------
ashutoshc has requested changes to the revision "HIVE-4016 [jira] Remove
init(fname) from TestParse.vm for each test".
Looks good. Please update result files if required.
INLINE COMMENTS
ql/src/test/templates/TestParse.vm:112 Do you mean that result files needs to
be updated? If so, can you update the result files and than update the patch
and than remove these statements.
REVISION DETAIL
https://reviews.facebook.net/D8547
BRANCH
HIVE-4016
ARCANIST PROJECT
hive
To: JIRA, ashutoshc, navis
> Remove init(fname) from TestParse.vm for each test
> --------------------------------------------------
>
> Key: HIVE-4016
> URL: https://issues.apache.org/jira/browse/HIVE-4016
> Project: Hive
> Issue Type: Improvement
> Components: Testing Infrastructure
> Reporter: Navis
> Assignee: Navis
> Priority: Trivial
> Attachments: HIVE-4016.D8547.1.patch
>
>
> TestParse does not change any of configuration or data, which means calling
> init() method before each test is not necessary. After removing it, test time
> reduced to 260sec to 16sec.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
